Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested elements getting ignored #178

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

alihassan143
Copy link
Contributor

@alihassan143 alihassan143 commented Jun 9, 2023

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #178 (b7c3503) into main (6677e2a) will increase coverage by 0.12%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   59.12%   59.24%   +0.12%     
==========================================
  Files         215      215              
  Lines        9774     9784      +10     
==========================================
+ Hits         5779     5797      +18     
+ Misses       3995     3987       -8     
Impacted Files Coverage Δ
lib/src/plugins/html/html_document_encoder.dart 84.05% <60.00%> (-0.99%) ⬇️
lib/src/plugins/html/html_document_decoder.dart 83.33% <96.29%> (+4.00%) ⬆️

... and 2 files with indirect coverage changes

@alihassan143
Copy link
Contributor Author

Expected
Screenshot 2023-06-09 at 5 34 01 PM
Rendered Result
Screenshot 2023-06-09 at 5 41 21 PM

@alihassan143
Copy link
Contributor Author

alihassan143 commented Jun 9, 2023

After Update

Screen.Recording.2023-06-09.at.5.38.59.PM.mov

@alihassan143
Copy link
Contributor Author

@LucasXu0 kindly review it

@alihassan143
Copy link
Contributor Author

@LucasXu0

@LucasXu0 LucasXu0 merged commit 27b50e5 into AppFlowy-IO:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants