Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:editor document to html encoder added #175

Merged
merged 4 commits into from
Jun 9, 2023
Merged

fix:editor document to html encoder added #175

merged 4 commits into from
Jun 9, 2023

Conversation

alihassan143
Copy link
Contributor

@alihassan143 alihassan143 commented Jun 7, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #175 (c63bd91) into main (eeae6fe) will increase coverage by 0.28%.
The diff coverage is 81.08%.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   58.83%   59.12%   +0.28%     
==========================================
  Files         215      215              
  Lines        9599     9774     +175     
==========================================
+ Hits         5648     5779     +131     
- Misses       3951     3995      +44
Impacted Files Coverage Δ
lib/src/plugins/html/html_document_decoder.dart 79.33% <60.86%> (-8.00%) ⬇️
lib/src/plugins/html/html_document_encoder.dart 85.03% <84.80%> (+85.03%) ⬆️

... and 14 files with indirect coverage changes

LucasXu0
LucasXu0 reviewed Jun 7, 2023
View reviewed changes
lib/src/plugins/html/html_document_decoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_decoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_decoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_encoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_encoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_encoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_encoder.dart Outdated Show resolved Hide resolved
lib/src/plugins/html/html_document_encoder.dart Outdated Show resolved Hide resolved
test/plugins/html/decoder/document_html_decoder_test.dart Outdated Show resolved Hide resolved
@alihassan143
Copy link
Contributor Author

@LucasXu0 @Xazin changes applied

@alihassan143
Copy link
Contributor Author

@LucasXu0 changes applied

@alihassan143
Copy link
Contributor Author

@LucasXu0 anything else needed let me know

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jun 9, 2023

LGTM.

@LucasXu0 LucasXu0 merged commit 6677e2a into AppFlowy-IO:main Jun 9, 2023
@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jun 9, 2023

@alihassan143 Is this PR will resolve the issue #174?

@alihassan143
Copy link
Contributor Author

@LucasXu0 yes previously div was ignored from special elements now its will be present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasXu0 LucasXu0 LucasXu0 left review comments

@Xazin Xazin Xazin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alihassan143 @LucasXu0 @Xazin