Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed image placeholder border color #119

Merged

Conversation

nurmukhametdaniyar
Copy link
Contributor

The image placeholder color now matches Divider's color, so it will be visible both on the light and dark themes

image image

@CLAassistant
Copy link

CLAassistant commented May 14, 2023

CLA assistant check
All committers have signed the CLA.

@nurmukhametdaniyar
Copy link
Contributor Author

Fixes AppFlowy-IO/AppFlowy#2362

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #119 (df326be) into main (d3394cb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files         127      127           
  Lines        7379     7379           
=======================================
  Hits         6411     6411           
  Misses        968      968           
Impacted Files Coverage Δ
lib/src/render/image/image_node_widget.dart 65.38% <100.00%> (ø)

@LucasXu0 LucasXu0 merged commit 51c9264 into AppFlowy-IO:main May 15, 2023
@nurmukhametdaniyar nurmukhametdaniyar deleted the image_placeholder_color branch May 16, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants