fix: unable to delete node on the mobile platform

AppFlowy-IO · Jun 1, 2023 · a7d2d32 · a7d2d32
1 parent c573b9a
commit a7d2d32
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 24 deletions.
diff --git a/example/lib/pages/simple_editor.dart b/example/lib/pages/simple_editor.dart
@@ -86,11 +86,10 @@ class SimpleEditor extends StatelessWidget {
     EditorState editorState,
     ScrollController? scrollController,
   ) {
-    return AppFlowyEditor.custom(
+    return AppFlowyEditor.standard(
       editorStyle: const EditorStyle.mobile(),
       editorState: editorState,
       scrollController: scrollController,
-      blockComponentBuilders: standardBlockComponentBuilderMap,
     );
   }
 

diff --git a/lib/src/editor/editor_component/service/ime/delta_input_on_delete_impl.dart b/lib/src/editor/editor_component/service/ime/delta_input_on_delete_impl.dart
@@ -12,22 +12,6 @@ Future<void> onDelete(
     return;
   }
 
-  // single line
-  if (selection.isSingle) {
-    final node = editorState.getNodeAtPath(selection.end.path);
-    final delta = node?.delta;
-    if (node == null || delta == null) {
-      return;
-    }
-
-    final transaction = editorState.transaction
-      ..deleteText(
-        node,
-        deletion.deletedRange.start,
-        deletion.textDeleted.length,
-      );
-    return editorState.apply(transaction);
-  } else {
-    throw UnimplementedError();
-  }
+  // use backspace command instead.
+  backspaceCommand.execute(editorState);
 }
diff --git a/.../editor/editor_component/service/shortcuts/command_shortcut_events/backspace_command.dart b/.../editor/editor_component/service/shortcuts/command_shortcut_events/backspace_command.dart
@@ -6,6 +6,7 @@ import 'package:flutter/material.dart';
 /// - support
 ///   - desktop
 ///   - web
+///   - mobile
 ///
 final CommandShortcutEvent backspaceCommand = CommandShortcutEvent(
   key: 'backspace',
@@ -111,10 +112,6 @@ CommandShortcutEventHandler _deleteLeftSentenceCommandHandler = (editorState) {
 };
 
 CommandShortcutEventHandler _backspaceCommandHandler = (editorState) {
-  if (PlatformExtension.isMobile) {
-    assert(false, 'backspaceCommand is not supported on mobile platform.');
-    return KeyEventResult.ignored;
-  }
   final selection = editorState.selection;
   if (selection == null) {
     return KeyEventResult.ignored;