Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings site issues #6701

Merged
merged 11 commits into from
Nov 5, 2024
Merged

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Nov 3, 2024

Feature Preview

  • add custom url and unpublish in more action menu (need adding test)
  • click the x button to clear home page (need adding test)
  • click the path name to open the published page (no test required)
  • add tooltip for publish page and publish page name (no test required)
  • block users before popup the update namespace dialog (no test required)
  • update translations (no test required)
  • remove the 'remove homepage button' from more action menu (remove the home page button test)
  • remove 'manage all sites' buttons (remove the manage all site button test)

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 added the v0.7.3 label Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 135 warning contribute (via Fink 🐦)

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.02%. Comparing base (7ecf213) to head (2f825b1).
Report is 217 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6701      +/-   ##
==========================================
- Coverage   74.41%   65.02%   -9.39%     
==========================================
  Files         245      273      +28     
  Lines        6566    10471    +3905     
  Branches     1057     1434     +377     
==========================================
+ Hits         4886     6809    +1923     
- Misses       1628     3494    +1866     
- Partials       52      168     +116     
Flag Coverage Δ
appflowy_web_app 65.02% <ø> (-9.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 54096b3 into AppFlowy-IO:main Nov 5, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant