Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: supported incremental updates #6531

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

qinluhe
Copy link
Collaborator

@qinluhe qinluhe commented Oct 11, 2024

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@qinluhe qinluhe force-pushed the fix/supported-incremental-updates branch from 36f680a to ef54736 Compare October 11, 2024 03:13
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 41.21622% with 174 lines in your changes missing coverage. Please review.

Project coverage is 65.02%. Comparing base (7ecf213) to head (ef54736).
Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
...pp/src/application/slate-yjs/utils/applyToSlate.ts 34.13% 135 Missing and 2 partials ⚠️
...b_app/src/application/slate-yjs/plugins/withYjs.ts 61.53% 9 Missing and 1 partial ⚠️
..._app/src/application/slate-yjs/utils/applyToYjs.ts 30.00% 7 Missing ⚠️
...b_app/src/application/slate-yjs/utils/positions.ts 40.00% 6 Missing ⚠️
...ents/toolbar/selection-toolbar/actions/Formula.tsx 0.00% 6 Missing ⚠️
...components/blocks/numbered-list/NumberListIcon.tsx 69.23% 2 Missing and 2 partials ⚠️
...web_app/src/application/slate-yjs/utils/convert.ts 50.00% 1 Missing ⚠️
...p/src/application/slate-yjs/utils/yjsOperations.ts 90.00% 1 Missing ⚠️
...omponents/editor/components/blocks/quote/Quote.tsx 0.00% 0 Missing and 1 partial ⚠️
...nts/editor/components/leaf/formula/FormulaLeaf.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6531      +/-   ##
==========================================
- Coverage   74.41%   65.02%   -9.39%     
==========================================
  Files         245      270      +25     
  Lines        6566    10377    +3811     
  Branches     1057     1406     +349     
==========================================
+ Hits         4886     6748    +1862     
- Misses       1628     3472    +1844     
- Partials       52      157     +105     
Flag Coverage Δ
appflowy_web_app 65.02% <41.21%> (-9.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinluhe qinluhe merged commit b5936ce into main Oct 11, 2024
8 of 10 checks passed
@qinluhe qinluhe deleted the fix/supported-incremental-updates branch October 11, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant