Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support shortcuts on web #6474

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Conversation

qinluhe
Copy link
Collaborator

@qinluhe qinluhe commented Oct 4, 2024

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 51.48005% with 377 lines in your changes missing coverage. Please review.

Project coverage is 66.49%. Comparing base (7ecf213) to head (5e6ab54).
Report is 105 commits behind head on main.

Files with missing lines Patch % Lines
...p/src/application/slate-yjs/utils/yjsOperations.ts 33.96% 171 Missing and 2 partials ⚠️
..._app/src/application/slate-yjs/utils/applyToYjs.ts 40.14% 84 Missing and 1 partial ⚠️
...web_app/src/application/slate-yjs/command/index.ts 46.15% 77 Missing ⚠️
...wy_web_app/src/components/editor/shortcut.hooks.ts 59.32% 21 Missing and 3 partials ⚠️
...wy_web_app/src/components/editor/utils/markdown.ts 94.44% 2 Missing and 3 partials ⚠️
...pp/src/components/editor/plugins/withInsertText.ts 60.00% 3 Missing and 1 partial ⚠️
...owy_web_app/src/components/main/useAppThemeMode.ts 60.00% 3 Missing and 1 partial ⚠️
...b_app/src/application/slate-yjs/plugins/withYjs.ts 75.00% 1 Missing ⚠️
...ppflowy_web_app/src/components/editor/Editable.tsx 0.00% 0 Missing and 1 partial ⚠️
...omponents/editor/components/blocks/quote/Quote.tsx 0.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6474      +/-   ##
==========================================
- Coverage   74.41%   66.49%   -7.92%     
==========================================
  Files         245      243       -2     
  Lines        6566     8988    +2422     
  Branches     1057     1149      +92     
==========================================
+ Hits         4886     5977    +1091     
- Misses       1628     2863    +1235     
- Partials       52      148      +96     
Flag Coverage Δ
appflowy_web_app 66.49% <51.48%> (-7.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinluhe qinluhe changed the title Feat/support basic editing on web feat: support shortcuts on web Oct 5, 2024
@qinluhe qinluhe force-pushed the feat/support-basic-editing-on-web branch 9 times, most recently from 62dd6eb to ab9d2c7 Compare October 7, 2024 08:58
@qinluhe qinluhe force-pushed the feat/support-basic-editing-on-web branch from ab9d2c7 to 5e6ab54 Compare October 7, 2024 10:25
@qinluhe qinluhe merged commit 19a3df6 into main Oct 7, 2024
7 checks passed
@qinluhe qinluhe deleted the feat/support-basic-editing-on-web branch October 7, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant