Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some UI issues were present in version 0.3.1. #3401

Merged
merged 11 commits into from
Sep 14, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Sep 14, 2023

Feature Preview

  • fix some ui issues

the text-align toolbar item is too small.
before
Screenshot 2023-09-13 at 16 54 11
after
Screenshot 2023-09-13 at 17 09 21

the scroll behavior of the outline plugin is too slow.

output.mp4

add a configuration to control whether to show the rename dialog when creating a view or not.
Screenshot 2023-09-13 at 22 06 11


PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 65.21% and project coverage change: -0.10% ⚠️

Comparison is base (9231455) 69.50% compared to head (40e8581) 69.41%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3401      +/-   ##
==========================================
- Coverage   69.50%   69.41%   -0.10%     
==========================================
  Files         496      499       +3     
  Lines       22720    22774      +54     
==========================================
+ Hits        15792    15808      +16     
- Misses       6928     6966      +38     
Flag Coverage Δ
appflowy_flutter_integrateion_test 67.30% <65.21%> (-0.10%) ⬇️
appflowy_flutter_unit_test 12.66% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tend/appflowy_flutter/lib/core/config/kv_keys.dart 0.00% <ø> (ø)
...or_plugins/actions/block_action_option_button.dart 32.35% <0.00%> (-1.50%) ⬇️
...ditor_plugins/outline/outline_block_component.dart 87.64% <0.00%> (ø)
.../editor_plugins/toggle/toggle_block_component.dart 94.11% <ø> (ø)
...tion/home/menu/sidebar/folder/personal_folder.dart 73.58% <0.00%> (+1.36%) ⬆️
frontend/appflowy_flutter/lib/core/config/kv.dart 35.71% <40.00%> (+1.33%) ⬆️
...plication/settings/create_file_settings_cubit.dart 50.00% <50.00%> (ø)
...entation/home/menu/sidebar/rename_view_dialog.dart 55.55% <55.55%> (ø)
...dgets/settings_appearance/create_file_setting.dart 81.81% <81.81%> (ø)
...cument/application/editor_transaction_adapter.dart 93.60% <100.00%> (+1.79%) ⬆️
... and 4 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 changed the title fix some issues in version 0.3.1 fix: some UI issues were present in version 0.3.1. Sep 14, 2023
@LucasXu0 LucasXu0 merged commit 26a2bff into AppFlowy-IO:main Sep 14, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant