Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve copy paste plugins, and support in-app copy-paste #3233

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Aug 18, 2023

Feature Preview

  • Support in-app copying and pasting.
  • Support copying the local image.
  • Improve the paste functionality for HTML.
  • Improve the paste functionality for plain text.
Screenshot 2023-08-18 at 15 54 51 Screenshot 2023-08-18 at 15 54 57 Screenshot 2023-08-18 at 15 55 07

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #3233 (e610938) into main (3015592) will decrease coverage by 0.21%.
The diff coverage is 56.42%.

@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   69.31%   69.10%   -0.21%     
==========================================
  Files         453      461       +8     
  Lines       21287    21505     +218     
==========================================
+ Hits        14755    14862     +107     
- Misses       6532     6643     +111     
Flag Coverage Δ
appflowy_flutter_integrateion_test 66.90% <56.42%> (-0.20%) ⬇️
appflowy_flutter_unit_test 12.72% <0.45%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lib/plugins/document/presentation/editor_page.dart 95.88% <ø> (ø)
...plugins/copy_and_paste/paste_from_in_app_json.dart 0.00% <0.00%> (ø)
...or_plugins/copy_and_paste/custom_copy_command.dart 21.42% <21.42%> (ø)
...y_and_paste/editor_state_paste_node_extension.dart 31.57% <31.57%> (ø)
...itor_plugins/copy_and_paste/clipboard_service.dart 70.37% <70.37%> (ø)
...editor_plugins/copy_and_paste/paste_from_html.dart 80.00% <80.00%> (ø)
...r_plugins/copy_and_paste/custom_paste_command.dart 86.95% <86.95%> (ø)
..._plugins/copy_and_paste/paste_from_plain_text.dart 88.88% <88.88%> (ø)
...ditor_plugins/copy_and_paste/paste_from_image.dart 92.30% <92.30%> (ø)
...nd/appflowy_flutter/lib/startup/deps_resolver.dart 72.72% <100.00%> (+0.72%) ⬆️

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant