Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle theme mode shortcut #2939

Merged
merged 2 commits into from
Jul 6, 2023
Merged

feat: toggle theme mode shortcut #2939

merged 2 commits into from
Jul 6, 2023

Conversation

MayurSMahajan
Copy link
Collaborator

@MayurSMahajan MayurSMahajan commented Jul 5, 2023

Solves: #2304

Feature Preview

2023-07-02.15-39-11.mp4

PR Checklist

  • My code adheres to the AppFlowy Style Guide
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2939 (89ff44b) into main (e0ad364) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
- Coverage   66.89%   66.88%   -0.02%     
==========================================
  Files         415      415              
  Lines       19767    19777      +10     
==========================================
+ Hits        13223    13227       +4     
- Misses       6544     6550       +6     
Flag Coverage Δ
appflowy_flutter_integrateion_test 64.48% <40.00%> (-0.09%) ⬇️
appflowy_flutter_unit_test 12.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._flutter/lib/workspace/application/appearance.dart 81.38% <0.00%> (-1.77%) ⬇️
...utter/lib/workspace/presentation/home/hotkeys.dart 66.66% <66.66%> (ø)

@MayurSMahajan MayurSMahajan requested a review from Xazin July 5, 2023 12:17
@Xazin Xazin merged commit 4805d0c into AppFlowy-IO:main Jul 6, 2023
@MayurSMahajan MayurSMahajan deleted the fr_toggle_theme_shortcut_2304 branch July 13, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants