Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19 - [FR] Successfully to build workable version for windows (Rust t… #21

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

pdckxd
Copy link
Contributor

@pdckxd pdckxd commented Nov 17, 2021

For issue #19

  1. scripts\flowy-tool\Cargo.toml
  • Remove shell dependency which does not support windows
  1. scripts\makefile\env.toml
  • Enhance environment checking for building app on windows
  1. scripts\flowy-tool\src\util\file.rs
  • Trim unnecessary prefix "\?" for std::fs::canonicalize(root) on windows
  1. scripts\makefile\flutter.toml
  • add dependency for "tasks.appflowy-windows" to copy dart_ffi.dll from rust build folder to flutter build folder
  1. scripts\flowy-tool\src\proto\proto_gen.rs
  • Remove dir by using platform independent code rather than calling *nix shell command
  1. scripts\makefile\protobuf.toml
  • tasks.gen_dart_event: call duckscript to gen_dart_event on windows platform

…ows (Rust target: x86_64-pc-windows-msvc), request to contribute

1. scripts\flowy-tool\Cargo.toml
  - Remove shell dependency which does not support windows
2. scripts\makefile\env.toml
  - Enhance environment checking for building app on windows
3. scripts\flowy-tool\src\util\file.rs
  - Trim unnecessary prefix "\\?\" for std::fs::canonicalize(root) on windows
4.  scripts\makefile\flutter.toml
  - add dependency for "tasks.appflowy-windows" to copy dart_ffi.dll from rust build folder to flutter build folder
5. scripts\flowy-tool\src\proto\proto_gen.rs
  - Remove dir by using platform independent code rather than calling *nix shell command
6. scripts\makefile\protobuf.toml
  - tasks.gen_dart_event: call duckscript to gen_dart_event on windows platform
Copy link
Contributor

@appflowy appflowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The BUILD_ON_WINDOWS.md is really helpful and impressive

@appflowy appflowy merged commit 6536098 into AppFlowy-IO:main Nov 17, 2021
appflowy added a commit that referenced this pull request Dec 10, 2021
#19 - [FR] Successfully to build workable version for windows (Rust t…
zoli referenced this pull request in LucasXu0/AppFlowy Aug 30, 2023
tests: improve test coverage for commands
839900146 pushed a commit to 839900146/AppFlowy that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants