-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shortcuts): Add Shortcuts to Help Menu #1870
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 37.11% 37.66% +0.55%
==========================================
Files 434 434
Lines 20260 20269 +9
==========================================
+ Hits 7519 7634 +115
+ Misses 12741 12635 -106
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Aman! Thanks for contributing to AppFlowy. Make sure you follow the steps in this doc https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/translation#steps-to-modify-an-existing-translation to generate the LocaleKeys class, only then you will be able to access LocalKeys.questionBubble_shortcuts.tr().
After the build command you may want to restart the app.
I think after you do the |
Hey there, I tried that but I am still facing the same issue. Any idea regarding what I could be doing wrong? If possible could you please check it by running at your end? |
Hey, @AmanNegi. You can just run # lucas.xu @ MacBook-Pro-6 in ~/Desktop/AppFlowy/frontend on git:main o [9:42:39]
$ sh ./scripts/generate_language_files.sh |
Hey there, it also results in the same error. |
Hey, @AmanNegi. Just let me help to fix it. |
Hey there, thanks a lot! Is there something I need to do from my end as of now? |
Hey @LucasXu0 Do I need to do something in order to accept your change/commits? Or should I make the same changes in my code? |
@AmanNegi , he's traveling. He should be able to get back to you by this week. Thanks for contributing! Hope your PR can get merged soon :D |
Oh Great! I also hope it gets merged ;) Thanks a lot |
- Added option of shorcuts in help menu - Clicking on the shortcut leads to the `Shortcuts.md` file
ef43205
to
879b110
Compare
Hey, @AmanNegi. I solved the conflicts and will merge this PR after the CI pass. |
@LucasXu0 Thanks a lot for helping me out 🙌 I want to contribute to this project further as well, could you tell me what I was doing wrong which was causing those errors in my local system? Thanks a lot again 🙂🤗 |
Hey, @AmanNegi. I executed the below commands in the
If you still run into this problem, just DM me on Discord. |
Oh yeah Thanks, Running the script resolves the issues 🎉 Also, your theme looks cool😎 |
😁 Here's the theme link. https://marketplace.visualstudio.com/items?itemName=RobbOwen.synthwave-vscode |
Shortcuts.md
fileFix for Issue: #1761