Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support markdown to italicize text #1059

Closed
annieappflowy opened this issue Sep 16, 2022 · 15 comments · Fixed by AppFlowy-IO/appflowy-editor#92
Closed

[FR] Support markdown to italicize text #1059

annieappflowy opened this issue Sep 16, 2022 · 15 comments · Fixed by AppFlowy-IO/appflowy-editor#92
Assignees
Labels
editor features related to the rich-text editor good first issue for devs for the community members to claim hacktoberfest help wanted for the community members to claim

Comments

@annieappflowy
Copy link
Collaborator

annieappflowy commented Sep 16, 2022

To italicize text, add one asterisk or underscore before and after a word or phrase. To italicize the middle of a word for emphasis, add one asterisk without spaces around the letters.

image

Reference:

@annieappflowy annieappflowy added help wanted for the community members to claim good first issue for devs for the community members to claim editor features related to the rich-text editor hacktoberfest labels Sep 16, 2022
@ankur12-1610
Copy link
Contributor

I would like to work on this issue!

@annieappflowy
Copy link
Collaborator Author

Thanks! Assigned to you. The mentor on this issue is @LucasXu0 . If you have any questions, please feel free to reach him out on Discord.

@JRS296
Copy link
Contributor

JRS296 commented Mar 19, 2023

Hey @annieappflowy, can I try working on this?

@LucasXu0
Copy link
Collaborator

Hi, @JRS296. Sure. We have implemented _abc_ to abc, but have not implemented the *abc* to abc yet.

@LucasXu0 LucasXu0 assigned JRS296 and unassigned ankur12-1610 Mar 20, 2023
@JRS296
Copy link
Contributor

JRS296 commented Mar 20, 2023

Cool, getting to work right away

@Xazin
Copy link
Collaborator

Xazin commented Mar 25, 2023

@JRS296 Hey JRS, if you need help feel free to let me know. I have this on a commit if you want some reference.

@JRS296
Copy link
Contributor

JRS296 commented Mar 26, 2023

@Xazin Hey there, I've located the root of the issue, and am clear on how to go about it; However I am having trouble setting up the dev environment. I've opened up an issue for the same ( Issue #2045 ). Feel free to share your thoughts on the same, would be really helpful 👍

@Xazin
Copy link
Collaborator

Xazin commented Mar 26, 2023

This commit (AppFlowy-IO/appflowy-editor@b6a2803) for the italic shortcut.

I will try during next week to see if I can replicate your issue on my Windows machine, currently away from home with my MacOS laptop.

Cheers

@JRS296
Copy link
Contributor

JRS296 commented Mar 26, 2023

Hey @Xazin , managed to fix the dev environment, it was due to the AntiVirus interfering with the build. Has this Feature request been implemented with your recent commit? If so, I'll start work on something else 👍

@Xazin
Copy link
Collaborator

Xazin commented Mar 26, 2023

I haven't made the PR, but I can do that later today, if you want to complete it feel free to do so. (You can take my commit and just add a test, and it's done)

@Xazin
Copy link
Collaborator

Xazin commented Apr 2, 2023

Resolved by #2115

@annieappflowy
Copy link
Collaborator Author

_ works but * doesn't work
I'm using v0.1.2

@JRS296
Copy link
Contributor

JRS296 commented Apr 7, 2023

I'll have a look into it 👍

@Xazin
Copy link
Collaborator

Xazin commented Apr 7, 2023

_ works but * doesn't work I'm using v0.1.2

This must be due to the fact that appflowy_editor was removed locally from the repo, and it now uses the AppFlowy Editor dependency instead.

Or so I would assume at least..

@annieappflowy
Copy link
Collaborator Author

annieappflowy commented Apr 23, 2023

* * not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor features related to the rich-text editor good first issue for devs for the community members to claim hacktoberfest help wanted for the community members to claim
Projects
Status: Done
5 participants