-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operator): Added support for creating managed pod disruption budgets #5911
Open
EricWittmann
wants to merge
11
commits into
main
Choose a base branch
from
feat/operator-pod-disruption
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricWittmann
changed the title
feat(operator): Added support for creating default pod disruption budgets
feat(operator): Added support for creating managed pod disruption budgets
Jan 24, 2025
jsenko
reviewed
Jan 27, 2025
operator/controller/src/main/resources/k8s/default/app.podDisruptionBudget.yaml
Outdated
Show resolved
Hide resolved
jsenko
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added some suggestions
...tor/controller/src/test/java/io/apicurio/registry/operator/it/PodDisruptionBudgetITTest.java
Show resolved
Hide resolved
...tor/controller/src/test/java/io/apicurio/registry/operator/it/PodDisruptionBudgetITTest.java
Outdated
Show resolved
Hide resolved
...tor/controller/src/test/java/io/apicurio/registry/operator/it/PodDisruptionBudgetITTest.java
Outdated
Show resolved
Hide resolved
...or/controller/src/main/java/io/apicurio/registry/operator/resource/ActivationConditions.java
Show resolved
Hide resolved
operator/model/src/main/java/io/apicurio/registry/operator/api/v1/spec/ComponentSpec.java
Outdated
Show resolved
Hide resolved
jsenko
force-pushed
the
feat/operator-pod-disruption
branch
from
January 29, 2025 20:55
8e7d3ca
to
c33386c
Compare
jsenko
force-pushed
the
feat/operator-pod-disruption
branch
from
January 30, 2025 12:20
7867c12
to
3a7cda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done for all components.