Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix double start of operator in tests #5364

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

andreaTP
Copy link
Member

This fixes the problem with the double start of the operator.
Unfortunately, it doesn't fix this TODO:

// TODO: The remote test does not work properly. As a workaround the CR will be deleted and recreated

@jsenko do you want to take a look?

@jsenko
Copy link
Member

jsenko commented Oct 21, 2024

This fixes the problem with the double start of the operator. Unfortunately, it doesn't fix this TODO:

// TODO: The remote test does not work properly. As a workaround the CR will be deleted and recreated

@jsenko do you want to take a look?

I tried to figure it out https://github.com/jsenko/apicurio-registry/tree/fix-operator-double-start-test but the remote test is still failing. It looks like the REGISTRY_API_URL variable is not removed even if it has been removed from the desired Deployment. So I don't know, it might be a bug in JOSDK?

@andreaTP
Copy link
Member Author

So I don't know, it might be a bug in JOSDK?

Would you be up doing a pairing session on this?
This PR should go in anyhow I guess ...

@andreaTP andreaTP enabled auto-merge (squash) November 4, 2024 09:45
@andreaTP andreaTP disabled auto-merge November 4, 2024 10:32
@andreaTP andreaTP merged commit 2bca64b into Apicurio:main Nov 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants