Go SDK #4134
Go SDK #4134
Conversation
| assert.Nil(t, err) | ||
| client := registryclientv2.NewApiClient(adapter) | ||
|
|
||
| info, err := client.System().Info().Get(context.Background(), nil) |
There was a problem hiding this comment.
this is the actual usage of the generated SDK by the user (and for a GET is pretty nice!)
| assert.Equal(t, "apicurio-registry", *info.GetName()) | ||
| } | ||
|
|
||
| func TestCreateAnArtifact(t *testing.T) { |
There was a problem hiding this comment.
and this is a POST to create an artifact etc. It looks like way too much work than necessary ...
| with: | ||
| go-version: '1.20' | ||
|
|
||
| - name: Build Registry |
There was a problem hiding this comment.
We must start considering having a previous step in building the project instead of building it in every single job (not saying it must be done in this PR, just making it clear).
There was a problem hiding this comment.
agree, that will be a nice optimization.
|
This makes me wonder, if we're generating now the Python SDK on this repo and also the Go SDK, shall we remove the notify-sdk-x jobs from the CI jobs? |
Yes, let me do it. |
|
ready to merge? |
There is still a gritty detail about disabling a compression middleware when performing POST operations ( ref ).
But we can iterate on it when we solve the issue upstream.
For the reviewers, skip the generated code and look at those:
go-sdk/pkg/tests/client_test.goas it shows the usage from a user perspective