Allow idempotent change to artifact state #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renjingxiao
force-pushed
the
state-idempotent
branch
2 times, most recently
from
2b51d95 to
0280d6c
Compare
carlesarnal
reviewed
Sep 12, 2023
| @@ -44,6 +44,7 @@ | |||
| import io.apicurio.registry.utils.ArtifactIdValidator; | |||
| import io.apicurio.registry.utils.IoUtil; | |||
| import io.apicurio.registry.utils.JAXRSClientUtil; | |||
| import io.apicurio.tenantmanager.api.datamodel.SortBy; | |||
There was a problem hiding this comment.
You have imported the wrong bean here. This bean must be coming from Registry, not from the tenant-manager.
carlesarnal
reviewed
Sep 12, 2023
| @@ -61,14 +61,17 @@ | |||
|
|
|||
| import io.apicurio.registry.AbstractResourceTestBase; | |||
| import io.apicurio.registry.rest.client.exception.RuleViolationException; | |||
| import io.apicurio.registry.rest.v1.beans.UpdateState; | |||
There was a problem hiding this comment.
The UpdateState from v1 is likely not needed.
carlesarnal
requested changes
Sep 12, 2023
| @@ -659,8 +664,12 @@ public void updateArtifactVersionState(String groupId, String artifactId, String | |||
| requireParameter("groupId", groupId); | |||
| requireParameter("artifactId", artifactId); | |||
| requireParameter("version", version); | |||
|
|
|||
| ArtifactMetaDataDto metaData = storage.getArtifactMetaData(defaultGroupIdToNull(groupId), artifactId); | |||
There was a problem hiding this comment.
This is not correct. If we are going to take the approach of looking up the current state from the storage, in this instance we need to get the artifact version state, not the artifact state. The reason is that this particular update is for a specific artifact version (notice that the method signature includes a version param).
So this needs to change to look up the metaData of a single version of the artifact from the storage.
renjingxiao
force-pushed
the
state-idempotent
branch
from
373d677 to
e073fa7
Compare
renjingxiao
force-pushed
the
state-idempotent
branch
from
c306309 to
14c1f87
Compare
EricWittmann
approved these changes
Sep 29, 2023
carlesarnal
pushed a commit
to carlesarnal/apicurio-registry
that referenced
this pull request
Nov 13, 2023
carlesarnal
added a commit
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (#3637) * Incorrect default value avro serialization (#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <138134862+Amoncy@users.noreply.github.com> Co-authored-by: Eric Wittmann <eric.wittmann@gmail.com> Co-authored-by: Jean Xiao <118199750+renjingxiao@users.noreply.github.com> Co-authored-by: Anshu Anna Moncy <amoncy@redhat.com> Co-authored-by: j2gg0s <j2gg0s@gmail.com>
carlesarnal
added a commit
to carlesarnal/apicurio-registry
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (Apicurio#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (Apicurio#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (Apicurio#3637) * Incorrect default value avro serialization (Apicurio#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (Apicurio#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <138134862+Amoncy@users.noreply.github.com> Co-authored-by: Eric Wittmann <eric.wittmann@gmail.com> Co-authored-by: Jean Xiao <118199750+renjingxiao@users.noreply.github.com> Co-authored-by: Anshu Anna Moncy <amoncy@redhat.com> Co-authored-by: j2gg0s <j2gg0s@gmail.com>
Merged
carlesarnal
added a commit
that referenced
this pull request
Nov 13, 2023
* Add null checks on role mapping (#3800) * Add null checks on role mapping * Add check for Role and Unit Test * Fixed a regression in the Settings page search box (#3798) * modified state change checks in ArtifactStateExt and AbstractSqlRegistryStorage (#3637) * Incorrect default value avro serialization (#3633) * Fix default value converter * Add test for default byte type value in converter test * Correct comment * added unit tests (#3593) * Bugfix: prase decimal's default --------- Co-authored-by: Amoncy <138134862+Amoncy@users.noreply.github.com> Co-authored-by: Eric Wittmann <eric.wittmann@gmail.com> Co-authored-by: Jean Xiao <118199750+renjingxiao@users.noreply.github.com> Co-authored-by: Anshu Anna Moncy <amoncy@redhat.com> Co-authored-by: j2gg0s <j2gg0s@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @EricWittmann and @carlesarnal ,
In this PR, I have added checks to ensure that the state can be changed to the same value multiple times. It works for both
/groups/{groupId}/artifacts/{artifactId}/stateand/groups/{groupId}/artifacts/{artifactId}/versions/{versionId}/stateendpoints. It may close #3475 .Thank you for reviewing it.