feat: support HTTPS passthrough ingress in the presence of redirects #3521
Conversation
jsenko
force-pushed
the
support-https-passthrough
branch
from
da29c71 to
69ad770
Compare
Not sure how to set it up easily, we would need the new system tests. But I've tested it manually, if that counts. |
| @Info(category = "redirects", description = "Override the port used for generating externally-accessible URLs.", availableSince = "2.5.0.Final") | ||
| Optional<Integer> urlOverridePort; | ||
|
|
||
| @ConfigProperty(name = "registry.url.override.port.remove") |
There was a problem hiding this comment.
Do we lose any semantics by removing this property and relying on the presence/absence of registry.url.override.port ?
Feels strange to have to set something, and have to set something more to remove it 😆
There was a problem hiding this comment.
You can have a k8s Service exposing HTTP on port 8123 for some reason. Then with default configuration we would remove the port and cause issues. The registry.url.override.port.remove property is basically a convenience to avoid setting registry.url.override.port to 443 or 80.
But I can remove the registry.url.override.port.remove functionality completely if it's confusing.
There was a problem hiding this comment.
I'll remove the property to make it less confusing
jsenko
force-pushed
the
support-https-passthrough
branch
from
69ad770 to
97c400f
Compare
|
@carlesarnal FYI:
do you think that is possible to merge an initial bulk of your effort and iterate over it? |
actually, I would like to merge the whole chunk of work during next week, all the tests are finally working, I need to port the native image workflows and we should be good to go and we can add this test as the first new one to the testsuite |
No description provided.