Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

chore: upgrade starknet-devnet #83

Merged
merged 3 commits into from
Aug 17, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Plugins for the [StarkNet Ethereum L2 networks](https://starkware.co/starknet/).

## Dependencies

* [python3](https://www.python.org/downloads) version 3.7 or greater, python3-dev
* [python3](https://www.python.org/downloads) version 3.7.2 or greater, python3-dev

## Installation

Expand Down
6 changes: 3 additions & 3 deletions ape_starknet/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ def extract_trace_data(trace: BlockSingleTransactionTrace) -> Dict[str, Any]:
# trace internals to select the most appropriate result. For instance, when `result`
# contains the additional value, we just need to use the "internal call" `result`
# that will contain the exact value the method returned.
invokation_result = trace_data["result"]
invocation_result = trace_data["result"]
internal_calls = trace_data["internal_calls"]
trace_data["result"] = (
internal_calls[-1]["result"] if internal_calls else invokation_result
) or invokation_result
internal_calls[-1]["result"] if internal_calls else invocation_result
) or invocation_result

return trace_data

Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@
"click>=8.1.0,<8.2",
"hexbytes>=0.2.2,<0.3",
"pydantic>=1.9.0,<2.0",
"eth-ape>=0.4.0,<0.5",
"eth-ape>=0.4.4,<0.5",
"ethpm-types>=0.3.3,<0.4",
"starknet.py>=0.4.4a0,<0.5",
"starknet-devnet==0.2.6",
"starknet-devnet>=0.2.9",
antazoey marked this conversation as resolved.
Show resolved Hide resolved
"importlib-metadata ; python_version<'3.8'",
],
entry_points={"ape_cli_subcommands": ["ape_starknet=ape_starknet._cli:cli"]},
Expand Down
1 change: 0 additions & 1 deletion tests/functional/test_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ def test_estimate_gas_cost_view_method(contract, account, provider):
assert provider.gas_price >= 100_000_000_000


@pytest.mark.xfail(reason="https://github.com/ApeWorX/ape/issues/931", strict=True)
def test_estimate_gas_cost_view_method_2(contract, account):
estimated_fee = contract.get_balance.estimate_gas_cost(account, sender=account)
assert estimated_fee > 100_000_000_000_000
4 changes: 3 additions & 1 deletion tests/integration/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ def invoke(
)

if ensure_successful:
assert result.exit_code == 0, result.output
cmd_str = " ".join(ape_cmd)
msg = f"CMD '{cmd_str}' failed with output '{result.output}'"
assert result.exit_code == 0, msg

return result.output

Expand Down