fix: estimate gas #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
feat/estimate-gas
branch
from
c45f58b to
e3f594a
Compare
fubuloubu
force-pushed
the
feat/estimate-gas
branch
from
e3f594a to
47d3e55
Compare
|
This seems to work well for me, but needs some update to the mock provider |
|
does this fix the need to provide |
fubuloubu
reviewed
Feb 23, 2024
|
the tests fail on main for the same reason; not sure what changed or why that suddenly happens. |
|
shipppppp itttttttttttt |
|
this is never gonna ship @antazoey forget about it |
why do you say this? |
fubuloubu
approved these changes
Feb 27, 2024
| def estimate_gas_cost( | ||
| self, receiver: AddressType, value: int, data: bytes, operation: int = 0 | ||
| ) -> Optional[int]: | ||
| return None # Estimate gas normally |
There was a problem hiding this comment.
I'm assuming this works in the tests, but if not I think the issue is likely that the gas prices are nonzero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
NOTE: Is only a POV - I havent tested yet.
fixes: #36
How I did it
How to verify it
Checklist