-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: python 3.12 #12
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@dtdang Figure out how to resolve the lint crisis:
It looks like we need to accept another lint dependency for this plugn for jupyter files. Make sure it is listed in both setup.py and pre-commit yaml for black's deps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the jupyter thing wasnt needed?
I guess the jupyter issue fixed itself. I'm not sure why the macos functional tests aren't working though. |
it is because i have to edit the GH settings to remove the macos-latest requirement and change to macos-12 requirement |
What I did
feat: add support for Python 3.12
chore: update lint dependencies
fixes: #
How I did it
How to verify it
Checklist