Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: python 3.12 #12

Merged
merged 2 commits into from
May 6, 2024
Merged

feat: python 3.12 #12

merged 2 commits into from
May 6, 2024

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented May 3, 2024

What I did

feat: add support for Python 3.12
chore: update lint dependencies

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from antazoey May 3, 2024 14:17
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@dtdang dtdang requested a review from Ninjagod1251 May 3, 2024 17:17
@antazoey
Copy link
Member

antazoey commented May 3, 2024

@dtdang Figure out how to resolve the lint crisis:

Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install "black[jupyter]"``

It looks like we need to accept another lint dependency for this plugn for jupyter files. Make sure it is listed in both setup.py and pre-commit yaml for black's deps!

Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the jupyter thing wasnt needed?

@dtdang
Copy link
Contributor Author

dtdang commented May 6, 2024

I guess the jupyter issue fixed itself. I'm not sure why the macos functional tests aren't working though.

@antazoey
Copy link
Member

antazoey commented May 6, 2024

I guess the jupyter issue fixed itself. I'm not sure why the macos functional tests aren't working though.

it is because i have to edit the GH settings to remove the macos-latest requirement and change to macos-12 requirement

@dtdang dtdang merged commit b988389 into ApeWorX:main May 6, 2024
15 checks passed
@dtdang dtdang deleted the feat/python3.12 branch May 6, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants