Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show call trace on transaction revert #164

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

mikeshultz
Copy link
Contributor

What I did

Shows call trace on transaction revert.

Ref: ApeWorX/ape#1945

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@mikeshultz mikeshultz added the category: feature New feature or request label Mar 6, 2024
@mikeshultz mikeshultz self-assigned this Mar 6, 2024
@mikeshultz
Copy link
Contributor Author

Test failure looks like it might be due to a node/hardhat version incompatibility (I fixed something similar on my local). Will take a look at the test failures tomorrow.

@mikeshultz mikeshultz marked this pull request as ready for review March 7, 2024 04:04
@mikeshultz mikeshultz requested a review from antazoey March 7, 2024 04:04
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but see my comment.. you can probably just ignore the case when there isnt a receipt and only a tx

ape_hardhat/provider.py Outdated Show resolved Hide resolved
@antazoey
Copy link
Member

antazoey commented Mar 7, 2024

Or maybe we will have to show the trace a different way in this case.

It is ok if it is ugly for now, there is a branch for 0.8 trace refactor we can bypass this a lot easier.

@mikeshultz mikeshultz merged commit a11a7fe into ApeWorX:main Mar 8, 2024
13 checks passed
@mikeshultz mikeshultz deleted the feat/trace branch March 8, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants