Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum Web Components #464

Closed
wants to merge 39 commits into from
Closed

Forum Web Components #464

wants to merge 39 commits into from

Conversation

dolf321
Copy link
Contributor

@dolf321 dolf321 commented Jul 21, 2023

Peek 2023-07-20 20-14

IT'S A LOT, so quick summary for our poor code reviewer:

  1. Added A rich text editor with easy usability for read only and write so we can reuse the component.
  2. Added a summary to the post list so you have an idea of what you're clicking.
  3. Create button, improved some css.
  4. Obviously created some basic linking to what i suppose the backend routes might be

Concerns:

  1. Had to make a CSS file for the editor, couldn't find any other way if you do please commit it.
  2. Hard-coded the data, couldn't really test the UI otherwise.

Future Must Have features:

  1. Liking/Upvoting
  2. Indication whether post has been answered or not
  3. Ability to tag people in posts/notifications
  4. Search functionality

@GusSand
Copy link
Collaborator

GusSand commented Jul 21, 2023 via email

@dolf321 dolf321 requested review from wabscale and synoet July 21, 2023 18:35
@dolf321
Copy link
Contributor Author

dolf321 commented Jul 21, 2023

Forgot to add refreshing for single post which we need for commenting, will reopen PR once i do.

@dolf321 dolf321 closed this Jul 21, 2023
@dolf321 dolf321 reopened this Jul 21, 2023
@dolf321 dolf321 requested a review from synoet July 22, 2023 07:09
wabscale pushed a commit that referenced this pull request Jul 31, 2023
@wabscale
Copy link
Collaborator

Squashed and rebased onto forum branch

@wabscale wabscale closed this Jul 31, 2023
wabscale pushed a commit that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants