Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary if available for each post #38

Open
AntoniosBarotsis opened this issue Dec 29, 2022 · 2 comments
Open

Add summary if available for each post #38

AntoniosBarotsis opened this issue Dec 29, 2022 · 2 comments
Assignees
@AntoniosBarotsis
Labels
enhancement New feature or request
Milestone
v1.0.2

Comments

@AntoniosBarotsis
Copy link
Owner

AntoniosBarotsis commented Dec 29, 2022 •
edited
Loading

This has been sort of mentioned in #6 but since the issue is taking a long time I made a separate one.

Description

The post struct has a description field which is currently not present in the generated HTML.

A config parameter could be added for the preferred max length of a description.

Notes

Some feeds seem to be using a description tag instead of the official summary tag so might as well try and parse both.
@AntoniosBarotsis AntoniosBarotsis converted this from a draft issue Dec 29, 2022
@AntoniosBarotsis AntoniosBarotsis self-assigned this Dec 29, 2022
@AntoniosBarotsis AntoniosBarotsis added the enhancement New feature or request label Dec 29, 2022
@AntoniosBarotsis AntoniosBarotsis added this to the v1.0.1 milestone Dec 29, 2022
@AntoniosBarotsis
Copy link
Owner Author

AntoniosBarotsis commented Jan 3, 2023 •
edited
Loading

Base functionality implemented in ad0f955. Will close once the note is also implemented.

@AntoniosBarotsis
Copy link
Owner Author

Note implemented in cd8168e. This will not be added yet at HTML inside of the descriptions often breaks the formatting.

AntoniosBarotsis added a commit that referenced this issue Jan 3, 2023
@AntoniosBarotsis
Removed description again. See #38
c89868c
@AntoniosBarotsis AntoniosBarotsis moved this from Todo to In Progress in Rss2Email Jan 3, 2023
@AntoniosBarotsis AntoniosBarotsis modified the milestones: v1.0.1, v1.0.2 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntoniosBarotsis AntoniosBarotsis

Labels
enhancement New feature or request
Projects
Rss2Email
Status: In Progress
Milestone
v1.0.2
Development

No branches or pull requests
1 participant
@AntoniosBarotsis