rename $cidr to $subnetMask because it is a subnet mask in cidr notation

AntonEvers · Oct 26, 2017 · 9457972 · 9457972
1 parent 9f8519b
commit 9457972
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/setup/src/Magento/Setup/Validator/IpValidator.php b/setup/src/Magento/Setup/Validator/IpValidator.php
@@ -72,10 +72,10 @@ private function filterIps(array $ips)
                 continue;
             }
 
-            $cidr = 32;
+            $subnetMask = 32;
             $ip = $range;
             if (strpos($range, '/') !== false) {
-                list($ip, $cidr) = explode('/', $range);
+                list($ip, $subnetMask) = explode('/', $range);
             }
 
             $ipValidator = new \Zend\Validator\Ip();
@@ -86,7 +86,7 @@ private function filterIps(array $ips)
 
             $ipv4Validator = new \Zend\Validator\Ip(['allowipv6' => false]);
             $maxBits = $ipv4Validator->isValid($ip) ? 32 : 128;
-            if ($cidr < 0 || $cidr > $maxBits) {
+            if ($subnetMask < 0 || $subnetMask > $maxBits) {
                 $this->invalidIps[] = $range;
                 continue;
             }