[1.0.3] Prometheus: Update speculative block metrics for produced blocks #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Oct 21, 2024
spoonincode
reviewed
Oct 21, 2024
| @@ -259,6 +259,7 @@ struct catalog_type { | |||
| net_usage_us_produced_block.Increment(metrics.net_usage_us); | |||
|
|
|||
| update(produced_metrics, metrics); | |||
| update(speculative_metrics, metrics); | |||
There was a problem hiding this comment.
it's okay that this increments speculative num_blocks_created right?
There was a problem hiding this comment.
Yes, I think so. If we want to report produced blocks also as speculative, seems we should report all the values.
linh2931
approved these changes
Oct 21, 2024
|
@matthewdarwin see any issue with this change? |
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the speculative block metrics for produced blocks.
Resolves #956