Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2 -> main] Test regression of syncing and replay with actual committed reference blockchain data #859

Closed
wants to merge 19 commits into from

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Oct 1, 2024

Forwards #827

To be confident that changes do not unintentionally introduce changes of the consensus protocol, we would like to add a testing utility that generates reference blockchain data and a new test that checks for regression in compatibility of syncing and replaying the reference blockchain data.

The PR

  • provides a command line option --save-blockchain to generate and save the reference blockchain data to unittests/test-data/consensus_blockchain directory. The full command is unittests/unit_test -t savanna_misc_tests/verify_block_compatibitity -- --save-blockchain.
  • loads the reference blockchain into a nodeos by replaying it, and and verifies the block ID of the replayed LIB matches with the ID of LIB in the reference blocks log.
  • starts another nodeos instance from reference snapshot, sync blocks from the replayed nodeos, and verifies resulting block ID.

Resolves #742

linh2931 and others added 19 commits September 26, 2024 17:55
…e saved if it needs to be changed in the future
[1.0.2] Fix reported time for produced blocks and fix confusing reported time name
[1.0.2] Test regression of syncing and replay with actual committed reference blockchain data
@linh2931 linh2931 requested review from heifner and greg7mdp October 1, 2024 21:43
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: Enhance test framework and test cases to sync and replay using actual committed reference blockchain data.
Note:end

@linh2931
Copy link
Member Author

linh2931 commented Oct 1, 2024

Close this PR as it pulled in #850 and forced me to resolve merge conflicts. It is replaced by #863

@linh2931 linh2931 closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test regression of syncing and replay with actual committed reference blockchain data
3 participants