IF: Test: Increase allowed unlinkable block exceptions during syncing #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Apr 26, 2024
|
Issue #69 mentioned |
I thought I had reported that number incorrectly and it was actually 129. I looked again. The first failure was 219 and the second was 129. So, 500 might be a better option. |
greg7mdp
approved these changes
Apr 26, 2024
linh2931
reviewed
Apr 27, 2024
tests/nodeos_startup_catchup.py
Outdated
| # See https://github.com/AntelopeIO/spring/issues/81 for fix to reduce the number of expected unlinkable blocks | ||
| # Test verifies LIB is advancing, check to see that not too many unlinkable block exceptions are generated | ||
| # while syncing up to head. | ||
| if contents.count("3030001 unlinkable_block_exception: Unlinkable block") > 500: |
There was a problem hiding this comment.
Can you log the count too so we know right away the number causing the violation.
linh2931
approved these changes
Apr 27, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this issue, just want to make the test more reliable and less sensitive to the number of unlinkable blocks that occurred during the test.
A separate issue #81 was created as a low-priority optimization to reduce the likelihood of these unlinkable blocks occurring during lib catchup syncing.
Resolves #69