Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.1 -> main] Make signed_block_ptr const #761

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 12, 2024

Change signed_block_ptr to be std::shared_ptr<const signed_block> instead of std::signed_block>.
Requires allowing fc::unpack of std::shared_ptr<T> to cast away const so it can be overwritten.
Didn't turn out too bad.

Merges release/1.0 into main including #744

@heifner heifner requested review from greg7mdp and arhag September 12, 2024 03:21
@heifner heifner added the OCI Work exclusive to OCI team label Sep 12, 2024
Base automatically changed from log-received-main to main September 12, 2024 03:38
@heifner heifner merged commit 406dbac into main Sep 12, 2024
36 checks passed
@heifner heifner deleted the GH-737-const-signed_block-main branch September 12, 2024 11:22
@ericpassmore
Copy link
Contributor

ericpassmore commented Sep 12, 2024

Note:start
category: Chores
component: Internal
summary: Utilize compiler to ensure blocks are treated as immutable after construction within implementation.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants