[1.0.1] Test: Rewrite P2P sync throttle test #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents the caller for having to wait or similarly verify.
…endpoint and simplify implementation. Hopefully this will make the test less flaky.
greg7mdp
approved these changes
Sep 5, 2024
linh2931
approved these changes
Sep 5, 2024
greg7mdp
approved these changes
Sep 6, 2024
linh2931
approved these changes
Sep 6, 2024
|
Note:start |
ericpassmore
added
the
test-instability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation was flaky and depended on prometheus endpoint of nodeos. It required catching a transient state reported by the prometheus endpoint. This was not reliable.
Now the test sets up two different syncing nodes. One that is heavily throttled and one that is not and verifies the throttled one syncs much slower.
Resolves #541