[1.0.1] P2P: syncing fix #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext_chunk() if sync_last_requested_num > 0 as a request was likely just made.
…plicable when no blocks are being received.
linh2931
approved these changes
Aug 29, 2024
plugins/net_plugin/net_plugin.cpp
Outdated
| @@ -2485,6 +2483,7 @@ namespace eosio { | |||
| return; | |||
| } | |||
| c->latest_blk_time = std::chrono::system_clock::now(); | |||
| sync_active_time = std::chrono::steady_clock::now(); // reset when we receive a block | |||
There was a problem hiding this comment.
You can do sync_active_time = c->latest_blk_time = std::chrono::system_clock::now(); to guarantee they are all the same.
greg7mdp
approved these changes
Aug 29, 2024
linh2931
approved these changes
Aug 29, 2024
|
Looks like |
greg7mdp
approved these changes
Aug 29, 2024
|
Note:start |
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small P2P syncing fixes:
sync_last_requested_numis 0 as that case is handled in the first part of theif. If we do request a new range, request from a potentially different peer. Noticed that in practice it would often stick to its current peer here as this would be the first time it realized it needs a new range of blocks.sync_active_timewhen a block is received. Noticed this "timer" was firing simply because it was taking too long to apply the blocks. I was testing withsync-fetch-spanof 5000.steady_clockfor stopwatch functionality.Resolves #670