Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Remove unnecessary code that cannot be executed. #558

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[1.0] Remove unnecessary code that cannot be executed. #558

merged 1 commit into from
Aug 15, 2024

Conversation

greg7mdp
Copy link
Contributor

As described in issue #534 (3rd small things at the end), we have a small test that cannot possibly be true, so this PR removes that dead code.

@greg7mdp greg7mdp requested review from heifner and linh2931 August 15, 2024 17:41
@heifner heifner changed the title Remove unnecessary code that cannot be executed. [1.0] Remove unnecessary code that cannot be executed. Aug 15, 2024
@greg7mdp greg7mdp merged commit 9d5fde1 into release/1.0 Aug 15, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_534_2 branch August 15, 2024 18:41
@greg7mdp greg7mdp mentioned this pull request Aug 15, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: INTERNALS
summary: Remove unnecessary code that cannot be executed.
Note:end

@arhag arhag added this to the Spring v1.0.0-rc2 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spring v1.0.0-rc2
Development

Successfully merging this pull request may close these issues.
5 participants
@greg7mdp @ericpassmore @heifner @linh2931 @arhag