Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to libsecp256k1 0.5.1 for small signing performance improvement #481

Merged
merged 1 commit into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions libraries/libfc/secp256k1/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ add_library(secp256k1-internal INTERFACE)
target_include_directories(secp256k1-internal INTERFACE secp256k1/src)

target_compile_definitions(secp256k1-internal INTERFACE ENABLE_MODULE_RECOVERY=1
ENABLE_MODULE_EXTRAKEYS=1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXTRAKEYS was added in #142 (comment) and as I suspected at that time, this was indeed a dependency oversight and has been fixed in 0.5.1.

COMB_BLOCKS=11
COMB_BLOCKS=43
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These COMB settings come from
https://github.com/bitcoin-core/secp256k1/blob/3fdf146bad042a17f6b2f490ef8bd9d8e774cdbd/CMakeLists.txt#L93-L105
notice the default setting is now 86 and the COMB defines match what is here.

COMB_TEETH=6
ECMULT_WINDOW_SIZE=15
SECP256K1_STATIC=1)
Expand Down