-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0-beta4] Some misc improvements #451
Conversation
…ocks. Also refactor terminate-at-block handling.
…xpired trxs on replay or if there are none.
@@ -4367,8 +4366,10 @@ struct controller_impl { | |||
break; | |||
} | |||
} | |||
dlog("removed ${n} expired transactions of the ${t} input dedup list, pending block time ${pt}", | |||
("n", num_removed)("t", total)("pt", now)); | |||
if (!replaying && total > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this removal. Was thinking about removing this spamming removed 0 expired transactions...
too.
Note:start |
fork_database_t::has_root()
.std::move
in assemble block.I could separate some/all of these into different PRs if desired.