Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta4] Some misc improvements #451

Merged
merged 8 commits into from
Jul 31, 2024
Merged

[1.0-beta4] Some misc improvements #451

merged 8 commits into from
Jul 31, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jul 31, 2024

  • Add missing mutex to fork_database_t::has_root().
  • When a block fails to produce, do not attempt to produce until the next block time stamp. This prevents a tight spin on failures. We had an issue somewhere for this, but can't find it. I found the problem when testing a possible alternative to [1.0-beta4] Misc improvements #448.
  • Refactors terminate-at-block handling into a function.
  • Additional std::move in assemble block.
  • Logging improvements
    • Do not log expired transaction count during replay.
    • Do not log expired transaction count if there are none.
    • Remove confusing "maybe switch forks" log statement.
    • Log block timestamp instead of wall clock time (which is always logged anyway) during start block.

I could separate some/all of these into different PRs if desired.

@heifner heifner requested review from greg7mdp and linh2931 July 31, 2024 12:56
@heifner heifner added the OCI Work exclusive to OCI team label Jul 31, 2024
@@ -4367,8 +4366,10 @@ struct controller_impl {
break;
}
}
dlog("removed ${n} expired transactions of the ${t} input dedup list, pending block time ${pt}",
("n", num_removed)("t", total)("pt", now));
if (!replaying && total > 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this removal. Was thinking about removing this spamming removed 0 expired transactions... too.

@heifner heifner merged commit 29743e4 into release/1.0-beta4 Jul 31, 2024
35 of 36 checks passed
@heifner heifner deleted the misc-beta4 branch July 31, 2024 18:04
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: INTERNALS
summary: Improvements to Finalizer, ForkDB, and Controller. Refactors code for readability, adds logging, and improves concurrency with additional mutex.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants