Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta1.2] P2P: Fix stuck in lib catchup #199

Merged
merged 1 commit into from
May 25, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 24, 2024

Test failure #190. The test creates a large fork and reestablishes the network between two large forked nodes. While the producer D was syncing into the network (which a very small sync-fetch-span == 5) it got stuck in lib catchup. Since it thought it was in lib catchup it would not send its produced blocks.

  • Fix for continuing to sync from a peer when we are receiving a group of blocks that we have already completely received. Go ahead and get the next range as the next range of blocks could be needed to resolve a large fork.

Resolves #190

@heifner heifner requested review from linh2931 and spoonincode May 24, 2024 13:20
@heifner heifner added the OCI Work exclusive to OCI team label May 24, 2024
@heifner heifner linked an issue May 24, 2024 that may be closed by this pull request
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Improve stability in P2P syncing for large forks with very small sync spans.
Note:end

@heifner heifner merged commit 11d1213 into release/1.0-beta1 May 25, 2024
312 of 316 checks passed
@heifner heifner deleted the GH-190-sync-lib-catchup branch May 25, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: lib_advance_test
4 participants