Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.0] Test: Use EOS mainnet chain values for integration tests #1172

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

heifner
Copy link
Member

@heifner heifner commented Feb 17, 2025

The prior max_transaction_cpu_usage of 475ms allowed for very long running speculative transactions. These could cause delays which, in some cases, would be long enough for a test to timeout. See #1151 for details.

To avoid other possible differences in tests and real-world, set all genesis values of integration tests to the current EOS mainnet values.

EOS Mainnet eosio global table values

https://eosauthority.com/account/eosio?network=eos&scope=eosio&table=global&limit=10&index_position=1&key_type=i64&reverse=0&mode=contract&sub=tables

max_block_net_usage target_block_net_usage_pct max_transaction_net_usage base_per_transaction_net_usage net_usage_leeway context_free_discount_net_usage_num context_free_discount_net_usage_den max_block_cpu_usage target_block_cpu_usage_pct max_transaction_cpu_usage min_transaction_cpu_usage max_transaction_lifetime deferred_trx_expiration_window max_transaction_delay max_inline_action_size max_inline_action_depth max_authority_depth
1048576 10000 524288 12 500 20 100 200000 10 150000 100 3600 600 3888000 524287 10 10

Resolves #1151

@heifner heifner added the OCI Work exclusive to OCI team label Feb 17, 2025
'max_authority_depth': 6
'max_inline_action_size': 524287,
'max_inline_action_depth': 10,
'max_authority_depth': 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those all EOS mainnet genesis values? Can you put a copy of current genesis configs in the PR description?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not EOS mainnet genesis values, they are current values. I'll add the current values to the description.

@heifner heifner merged commit 71999c3 into release/1.1 Feb 18, 2025
36 checks passed
@heifner heifner deleted the GH-1151-test-genesis-1.1 branch February 18, 2025 14:20
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Internal
summary: To avoid other possible differences in tests and real-world, set all genesis values of integration tests to the current EOS mainnet values.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants