Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fsi serialization implementation to support dynamically size serialized blobs #617

Closed
arhag opened this issue Aug 22, 2024 · 0 comments · Fixed by #624 or #648
Closed

Update fsi serialization implementation to support dynamically size serialized blobs #617

arhag opened this issue Aug 22, 2024 · 0 comments · Fixed by #624 or #648
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@arhag
Copy link
Member

arhag commented Aug 22, 2024

Currently the serializer for fsi assumes each finalizer's fsi is fixed size when serialized. We want to update this to work even when each finalizer's serialized fsi can vary in size.

To preserve the optimization that we do not write out the fsi of inactive finalizers on each write, their serialized data should be written first in the file and the fsi for the active finalizers should come after.

The version for the fsi file should be bumped to version 1 so that we can still support version 0 fsi files.

For now, the fsi record for each finalizer that is being serialized does not change. That will happen in a later issue. But this should still create the infrastructure needed to upgrade a version 0 fsi struct to a version 1 fsi struct (which will be useful later) even though currently they would be two different structs that have the same exact members.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 22, 2024
@bhazzard bhazzard added this to the Spring v1.0.0-rc3 milestone Aug 22, 2024
@bhazzard bhazzard added 👍 lgtm and removed triage labels Aug 22, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 22, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Aug 22, 2024
heifner added a commit that referenced this issue Aug 27, 2024
[1.0] Update FSI serialization to support dynamically sized data and verify a checksum
heifner added a commit that referenced this issue Aug 27, 2024
heifner added a commit that referenced this issue Aug 27, 2024
[1.0 -> main] Update FSI serialization to support dynamically sized data and verify a checksum
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment