-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fsi serialization implementation to support dynamically size serialized blobs #617
Comments
heifner
added a commit
that referenced
this issue
Aug 23, 2024
heifner
added a commit
that referenced
this issue
Aug 26, 2024
heifner
added a commit
that referenced
this issue
Aug 26, 2024
heifner
added a commit
that referenced
this issue
Aug 27, 2024
[1.0] Update FSI serialization to support dynamically sized data and verify a checksum
heifner
added a commit
that referenced
this issue
Aug 27, 2024
[1.0 -> main] Update FSI serialization to support dynamically sized data and verify a checksum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the serializer for fsi assumes each finalizer's fsi is fixed size when serialized. We want to update this to work even when each finalizer's serialized fsi can vary in size.
To preserve the optimization that we do not write out the fsi of inactive finalizers on each write, their serialized data should be written first in the file and the fsi for the active finalizers should come after.
The version for the fsi file should be bumped to version 1 so that we can still support version 0 fsi files.
For now, the fsi record for each finalizer that is being serialized does not change. That will happen in a later issue. But this should still create the infrastructure needed to upgrade a version 0 fsi struct to a version 1 fsi struct (which will be useful later) even though currently they would be two different structs that have the same exact members.
The text was updated successfully, but these errors were encountered: