Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: Sync mode stuck after hitting max-reversible-blocks, after restart #565

Closed
heifner opened this issue Aug 16, 2024 · 1 comment · Fixed by #572 or #591
Closed

P2P: Sync mode stuck after hitting max-reversible-blocks, after restart #565

heifner opened this issue Aug 16, 2024 · 1 comment · Fixed by #572 or #591
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.0-rc2

Comments

@heifner
Copy link
Member

heifner commented Aug 16, 2024

After hitting max-reversible-blocks during a read-mode = irreversible sync, upon restart the node is stuck in already syncing, start sync ignored.

Hitting max-reversible-blocks should be avoided after #545. Need to investigate why node is stuck in already syncing, start sync ignored and also test #545 with the reported config.ini.

max-reversible-blocks may not work correctly with read-mode = irreversible.
@heifner heifner self-assigned this Aug 16, 2024
@heifner heifner added OCI Work exclusive to OCI team bug The product is not working as was intended. labels Aug 16, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 16, 2024
@heifner heifner added this to the Spring v1.0.0-rc2 milestone Aug 16, 2024
@heifner
Copy link
Member Author

heifner commented Aug 16, 2024

This is a different issue than #530. #530 got stuck when a block was rejected. This was stuck because it already had all the blocks requested in its forkdb, but none had been applied because the node was running in irrevsersible mode.

@arhag arhag added 👍 lgtm and removed triage labels Aug 16, 2024
heifner added a commit that referenced this issue Aug 17, 2024
@heifner
GH-565 Add test that trips issue of 565, sync start after restart of …
5a6f76c 
…a node that was terminated with many blocks in the forkdb
@heifner heifner mentioned this issue Aug 17, 2024
Closed
heifner added a commit that referenced this issue Aug 17, 2024
@heifner
GH-565 if on start sync the current sync has recieved all its blocks,…
1eb8318 
… attempt to request the next range of block instead of ignoring the request.
heifner added a commit that referenced this issue Aug 17, 2024
@heifner
GH-565 On startup if no peers configured, then attempt to apply block…
61ebd0f 
…s from the fork database. This allows a block stuck in a condition where it has too many blocks in the forkdb to process new blocks to attempt to apply those blocks on startup.
@heifner heifner mentioned this issue Aug 17, 2024
Merged
@heifner heifner linked a pull request Aug 17, 2024 that will close this issue
[1.0] Normally process blocks from the forkdb on startup #572
Merged
heifner added a commit that referenced this issue Aug 17, 2024
@heifner
GH-565 Always log state of fork database on startup.
a48dc06
heifner added a commit that referenced this issue Aug 18, 2024
@heifner
Merge branch 'release/1.0' into GH-565-sync-stuck
03589b9
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Aug 19, 2024
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge pull request #572 from AntelopeIO/GH-565-sync-stuck
792e19d 
[1.0] Normally process blocks from the forkdb on startup
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-565-sync-st…
35f81a4 
…uck-main
@heifner heifner mentioned this issue Aug 19, 2024
Merged
heifner added a commit that referenced this issue Aug 19, 2024
@heifner
Merge pull request #591 from AntelopeIO/GH-565-sync-stuck-main
fa53ec9 
[1.0 -> main] Normally process blocks from the forkdb on startup
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 19, 2024
@heifner heifner mentioned this issue Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Spring v1.0.0-rc2
3 participants
@heifner @arhag @enf-ci-bot