GH-376 Move check into EOS_ASSERT instead of hard-coding false

AntelopeIO · Jul 24, 2024 · 8994ac0 · 8994ac0
1 parent 77e9f7e
commit 8994ac0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/libraries/chain/finality/qc.cpp b/libraries/chain/finality/qc.cpp
@@ -313,8 +313,8 @@ void aggregating_qc_t::verify_qc(const qc_t& qc, const digest_type& strong_diges
    if (qc.pending_policy_sig) {
       EOS_ASSERT(pending_finalizer_policy, invalid_qc_claim,
                  "qc ${bn} contains pending policy signature for nonexistent pending finalizer policy", ("bn", qc.block_num));
-   } else if (pending_finalizer_policy) {
-      EOS_ASSERT(false, invalid_qc_claim,
+   } else {
+      EOS_ASSERT(!pending_finalizer_policy, invalid_qc_claim,
                  "qc ${bn} does not contain pending policy signature for pending finalizer policy", ("bn", qc.block_num));
    }