-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty antler-run with eos-vm and eosiolib linked #94
Conversation
This reverts commit f926d59.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, other than that looking good.
libraries/native/macho_crt.s
Outdated
mov %rdx, %rsp | ||
mov 56(%rdi), %rdx | ||
jmp *%rdx | ||
syscall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this macho_crt.s for the time being as we don't support mac os directly for the foreseeable future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to do this in a separate commit, as there are few more places with mac os specifics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this break anything currently in use? If it does then let's make a branch called next_release
and merge to that.
@larryk85 tests are fine and binary workflow supposed to be unchanged, I made two different implementations - |
This reverts commit 226f497.
#79
Challenges:
eosiolib
haven't been built withgcc
. it was only built withcdt-cpp
before. However when we includedeosiolib
intoantler-run
we got chicken and egg problem: all tools are built with default compiler (gcc in case of Ubuntu) and theneosiolib
built with those tools. Solution was to slightly changeeosiolib
to be built with gcc. So now we have two versions ofeosiolib
lib for different purposes.libraries/libc++
. The reason to use standard library is because of we addeos-vm
as well and there were a lot to fix to get it along with customlibc++
.Libc++
lacksfstream
and other stuff that is needed byeos-vm
.antler-run
. Issue with it was that we can't have our own_start
with standard library. So this code was split to avoid this function included forantler-run
binary.native
library now also has two native builds with different toolchains (gcc and cdt-cpp).Note: there is a decision to remove Mac support. This PR maintains Mac support in order to makes changes distinct. I'm planning to make another PR to remove Mac support.
Change Description
API Changes
Documentation Additions