Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Change BLS library to use Base64 URL encoding/decoding; update Base64 library to match Leap's #272

Merged
merged 19 commits into from
Mar 11, 2024
Merged

IF: Change BLS library to use Base64 URL encoding/decoding; update Base64 library to match Leap's #272

merged 19 commits into from
Mar 11, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Mar 11, 2024 •
edited
Loading

Update CDT to match Leap after AntelopeIO/leap#2061.

  • Update CDT Base64 library's base64 URL encoding/decoding to match Leap's.
  • Change CDT BLS to use base64 URL encoding/decoding.
  • Add new tests and adapt existing tests for base64 URL encoding/decoding.

Resolve #271 and #268.

Change Description

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

dougbutner and others added 18 commits December 13, 2023 12:22
@dougbutner
UPDATE Link to latest patch of CDT (4.0.1)
a2e3f3f
@ericpassmore
Reverts operations to multi-index that created alias for existing ope…
589faab 
…rations

This reverts commit 65f928f.
@ericpassmore
Revert "Update tests to cover both const and non-const version of rem…
5634784 
…ove()"

This reverts commit a1aae5f.
@ericpassmore
Revert "Get rid of const obj for new modify() method."
47e1b51 
This reverts commit 2b0fd5c.
@ericpassmore
Revert "Add insert, remove and update methods to multi_index (and ind…
d31c73a 
…ex)"

This reverts commit 94ca050.
@spoonincode
export wasm memory
3b07180
@spoonincode
Merge pull request #256 from dougbutner/main
6cda379 
UPDATE Link to latest patch of CDT (4.0.1)
@spoonincode
Merge pull request #265 from AntelopeIO/export_wasm_memory
b9e8265 
export wasm memory
@ericpassmore
Merge pull request #262 from AntelopeIO/ehp/gh-260-revert-db-index-op…
6906563 
…-names

Revert Alias of Multi-Index Operations
@ericpassmore
updated build&test to use ubuntu22 leap
fd49c7b
@ericpassmore
specify os version in leap dev download file
b8b9318
@ericpassmore
specify os version in leap dev download file
0d42f9b
@ericpassmore
Merge pull request #270 from AntelopeIO/ehp/gh-269-use-ubuntu22-leap-dev
26289ff 
Updated Build&Test to use ubuntu22 leap
@linh2931
do not append trailing = to base64url encoding
b067f1c
@linh2931
Do not allow base64 chars (+, /, and =) when decoding base64url, to m…
42c0a9d 
…atch with Leap base64url decode behavior
@linh2931
add tests to verify base64url_decode reject invalid chars and update …
28794f4 
…existing tests
@linh2931
change BLS library to use base64 URL for encoding and decoding
75eb06e
@linh2931
Adapt BLS and instant_finality tests to base64 URL
26414ad
@arhag arhag linked an issue Mar 11, 2024 that may be closed by this pull request
Update base64 implementation and BLS encoding/decoding #271
Closed
@linh2931 linh2931 mentioned this pull request Mar 11, 2024
Closed
2 tasks
@linh2931 linh2931 merged commit dc1019e into hotstuff_integration Mar 11, 2024
6 checks passed
@linh2931 linh2931 deleted the bls_base64url_support branch March 11, 2024 22:13
@linh2931 linh2931 linked an issue Mar 11, 2024 that may be closed by this pull request
hotstuff_integration CDT Integration Tests Fail #268
Closed
@ericpassmore
Copy link
Contributor

ericpassmore commented Mar 12, 2024 •
edited
Loading

Note:start
group: IF
category: INTERNALS
summary: Easier to use format for BLS keys, and match Leap's implementation. Includes tests.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@spoonincode spoonincode Awaiting requested review from spoonincode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update base64 implementation and BLS encoding/decoding hotstuff_integration CDT Integration Tests Fail
6 participants
@linh2931 @ericpassmore @greg7mdp @heifner @dougbutner @spoonincode