update changelog #883
Merged
update changelog #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-zakir
commented
Jul 26, 2024
a-zakir
commented
- New output file criterions.txt is added under lp/ dir to store adequacy criterions for all valid patterns (area+criterion)
- New output file PositiveUnsuppliedEnergy.txt is added under lp/ dir to store the amount of unsupplied energy for all valid patterns (area+criterion)
tbittar
previously requested changes
Jul 26, 2024
|
flomnes
reviewed
Aug 6, 2024
| @@ -47,3 +47,5 @@ Several log files are written: | |||
|
|
|||
| - `reportbenders.txt` gives information on the progress of the algorithm with an operational perspective, | |||
| - `benders_solver.log` contains more detailed information on all data of interest to follow the progress of the algorithm (`lambda_min`, `lambda_max`, detailed solving times, ...). | |||
| - The file `criterions.txt` under `lp/` dir stores adequacy criterions for all valid patterns (area+criterion) | |||
| - The file `PositiveUnsuppliedEnergy.txt` under `lp/` dir stores the amount of unsupplied energy for all valid patterns (area+criterion) | |||
There was a problem hiding this comment.
Can we rename this file to just unsuppliedEnergy.txt ?
We have the following convention
- Unsupplied energy
- Spilled energy
There was a problem hiding this comment.
no, that's the variable name in mps
flomnes
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.