Fix sonar issues

[JasonMarechal25]

• Remove FakeWorkerMaqter from tests. Doesn't seems to do anything
• Remove dynamique allocation of WorkerMaster. Replace with perfect forwarding arguments from reset_master function to make_shared
• Add return value to non void function

[flomnes]

Linking fails on ubuntu, maybe the template definition is missing from this translation unit ?

antares-xpansion/src/cpp/benders/benders_mpi/BendersMPI.cpp:52: undefined reference to `void BendersBase::reset_master<WorkerMaster, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >&, std::filesystem::__cxx11::path, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, int&, SolverLogManager&, bool, std::shared_ptr<ILogger>&>(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >&, std::filesystem::__cxx11::path&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, int&&, int&, SolverLogManager&, bool&&, std::shared_ptr<ILogger>&)'

[flomnes]

Fix linking and we're good

[JasonMarechal25]

Linking fails on ubuntu, maybe the template definition is missing from this translation unit ?

antares-xpansion/src/cpp/benders/benders_mpi/BendersMPI.cpp:52: undefined reference to `void BendersBase::reset_master<WorkerMaster, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >&, std::filesystem::__cxx11::path, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, int&, SolverLogManager&, bool, std::shared_ptr<ILogger>&>(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >&, std::filesystem::__cxx11::path&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, int&&, int&, SolverLogManager&, bool&&, std::shared_ptr<ILogger>&)'

Strange it works on my end

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud