fix mc-years bug --windows #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-zakir
force-pushed
the
fix/issue-688-windows-bug
branch
from
64b3a20 to
c4ef40a
Compare
| @@ -21,40 +21,41 @@ SolverFactory::SolverFactory() { | |||
|
|
|||
| SolverAbstract::Ptr SolverFactory::create_solver( | |||
| const std::string &solver_name, const SOLVER_TYPE solver_type) const { | |||
| return create_solver(solver_name, solver_type, ""); | |||
| auto log_manager = SolverLogManager(""); | |||
There was a problem hiding this comment.
J'ai l'impression qu'on a une "dangling reference" ici, ou un problème de gestion de la durée de vie des file pointers.
log_manager est créé sur la stack dans le scope de create_solver. On créé des solver qui vont pointer sur les FP de log_manager.
Quand on retourne un solver, on sort du scope, log_manager est détruit, donc on ferme le FP. Par contre les solver sont vivant et vont vouloir écrire dans les FP
|
Kudos, SonarCloud Quality Gate passed! |
JasonMarechal25
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close AntaresXpansion - number of MC years #688