read variables from mps #648
Conversation
|
SonarCloud Quality Gate failed. |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method RunProblemGeneration.cpp: RunProblemGeneration
- Excess Number of Function Arguments LinkProblemsGenerator.cpp: LinkProblemsGenerator::treatloop 🔥
There was a problem hiding this comment.
❌ Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method RunProblemGeneration.cpp: RunProblemGeneration
- Excess Number of Function Arguments LinkProblemsGenerator.cpp: LinkProblemsGenerator::treatloop 🔥
…bles_from_mps # Conflicts: # antares-version.json # src/cpp/lpnamer/input_reader/GeneralDataReader.h
| @@ -83,7 +83,7 @@ def launch_and_compare_lp_with_reference(install_dir, master_mode, test_dir): | |||
| study_dir = test_dir.resolve() | |||
| os.chdir(test_dir.parent) | |||
| launch_command = [str(lp_namer_exe), "-o", str(study_dir), "-a", str(zip_path), | |||
| "-e", "contraintes.txt", "-f", master_mode] | |||
| "-e", "contraintes.txt", "-f", master_mode, "--unnamed-problems"] | |||
There was a problem hiding this comment.
If I understand properly, "unnamed-problems" is "legacy" behaviour ?
There was a problem hiding this comment.
exactly, reference mps in theses tests are unnamed
| self.zip_option] | ||
| cmd = [str(self.antares_exe_path), self.data_dir, self.ANTARES_N_CPU_OPTION, str(self.antares_n_cpu), self.zip_option] | ||
| if(version.parse(__antares_simulator_version__) >= version.parse(self.FIRST_VERSION_WITH_NAMED_PROBLEMS)): | ||
| cmd.append("--named-problems") |
There was a problem hiding this comment.
For legacy studies, keep behaviour as it is.
For newer studies, use named-problems.
Is that it ?
Do we always want named problems though? Or do we just want to support the feature?
There was a problem hiding this comment.
well, for simulator v8.7 and newer, we're forced to use named mps because variables.txt files are no longer produced.
…bles_from_mps # Conflicts: # vcpkg
… into feature/read_variables_from_mps
|
SonarCloud Quality Gate failed.
|
add ability to read mps with named variables in Problem Generation