Skip to content

Commit

Permalink
Fix criterion computation (#817)
Browse files Browse the repository at this point in the history
The weight of the criterion is only given by `subproblem_weight` which
already takes into account the number of scenarios. This PR is just a
quick fix, further work will be needed to clean the useless information
about scenario retrieval from configuration file, see #818 .
  • Loading branch information
tbittar authored May 17, 2024
1 parent 170b15a commit 1531c00
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cpp/benders/benders_core/BendersBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,7 @@ std::vector<double> BendersBase::ComputeOuterLoopCriterion(
solution > criterion_count_threshold)
// 1h of no supplied energy
outer_loop_criterion_per_sub_problem[pattern_index] +=
subproblem_weight / number_of_scenarios;
subproblem_weight;
}
}
return outer_loop_criterion_per_sub_problem;
Expand Down

0 comments on commit 1531c00

Please sign in to comment.