fix(launcher-api): remove orphan JobResults visibility permissions #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabw-rte
force-pushed
the
bugfix/1970-jobs-user-permissions
branch
from
9e44b59
to
5a22347
Compare
mabw-rte
changed the title
MartinBelthle
requested changes
Aug 29, 2024
|
You can also remove the import of |
mabw-rte
force-pushed
the
bugfix/1970-jobs-user-permissions
branch
from
6496d7b
to
a7c8994
Compare
sylvlecl
approved these changes
Aug 29, 2024
MartinBelthle
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In the job listing of
AntaREST, we call two endpoints:GET,v1/launcher/jobsGET,v1/launcher/jobs/{job_id}/progressIt turns out that when user does not have a permission for some job, this job, though listed (using the first endpoint of
jobs), spits out an error403when it is called for the second endpointprogress.Issue:
For the endpoint
jobs, the logic beyond the permissions includes a second option where when an orphan job is created recently enough would become visible to everyone. This logic was not included in theprogressendpoint which leads to theExceptionabove.Solution:
After consulting the application users, they think that this
orphanvisibility logic is not that much relevant and should be removed (at least temporarily).