feat(outputs): build outputs tree based on filesystem #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
changed the title
mc-all and mc-ind trees based on filesystem
laurent-laporte-pro
suggested changes
Jun 17, 2024
antarest/study/storage/rawstudy/model/filesystem/common/area_matrix_list.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/common/area_matrix_list.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/common/area_matrix_list.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/common/area_matrix_list.py
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/common/area_matrix_list.py
Outdated
Show resolved
Hide resolved
laurent-laporte-pro
suggested changes
Jun 17, 2024
laurent-laporte-pro
suggested changes
Jun 17, 2024
There was a problem hiding this comment.
Merci pour ce refactoring.
Une observation : à présent que la vérification de l’existence des fichiers et dossiers de sortie est effectuée, j'espère que cela ne ralentira pas le parsing d'une étude. Il est possible qu'on observe une dégradation des performances à l'ouverture d'une étude. Cela dit, si ça évite des anomalies côté utilisateur, c'est toujours bon à prendre.
antarest/study/storage/rawstudy/model/filesystem/root/output/simulation/mode/common/areas.py
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/root/output/simulation/mode/common/utils.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/root/output/simulation/mode/common/utils.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/root/output/simulation/mode/common/set.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/root/output/simulation/mode/common/set.py
Show resolved
Hide resolved
| @@ -56,17 +56,18 @@ def build(self) -> TREE: | |||
|
|
|||
| class OutputSimulationTsGenerator(FolderNode): | |||
| def build(self) -> TREE: | |||
| children: TREE = { | |||
| "hydro": OutputSimulationTsGeneratorCustomMatrixList( | |||
| children: TREE = {} | |||
There was a problem hiding this comment.
Cette partie du code n'est pas couverte pas les tests unitaires.
There was a problem hiding this comment.
I believe it's because the ts-generator part is not supported yet in AntaresWeb.
.../study/storage/rawstudy/model/filesystem/root/output/simulation/mode/common/binding_const.py
Show resolved
Hide resolved
.../study/storage/rawstudy/model/filesystem/root/output/simulation/mode/common/binding_const.py
Show resolved
Hide resolved
antarest/study/storage/rawstudy/model/filesystem/root/output/simulation/mode/mcind/mcind.py
Outdated
Show resolved
Hide resolved
...rest/study/storage/rawstudy/model/filesystem/root/output/simulation/ts_numbers/ts_numbers.py
Show resolved
Hide resolved
laurent-laporte-pro
force-pushed
the
feat/build-outputs-based-on-filesystem
branch
from
f9dce4f
to
31b69d7
Compare
MartinBelthle
force-pushed
the
feat/build-outputs-based-on-filesystem
branch
2 times, most recently
from
c71ff8d
to
d7c0918
Compare
MartinBelthle
force-pushed
the
feat/build-outputs-based-on-filesystem
branch
from
8db4c20
to
58cdeeb
Compare
laurent-laporte-pro
approved these changes
Jun 25, 2024
laurent-laporte-pro
force-pushed
the
feat/build-outputs-based-on-filesystem
branch
from
cb37c6e
to
f11baf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves [ANT-1306]