fix(bc): only remove terms when asked #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
fix/do-not-remove-terms-in-bc
branch
from
6f06908
to
07985c3
Compare
laurent-laporte-pro
previously approved these changes
Jun 10, 2024
| terms_to_remove = {key for key in updated_cfg if ("%" in key or "." in key) and key not in updated_terms} | ||
| for term_id in terms_to_remove: | ||
| updated_cfg.pop(term_id, None) | ||
| updated_properties = self.dict(exclude={"command_context", "command_name", "version", "id"}, exclude_none=True) |
There was a problem hiding this comment.
You should use:
excluded_fields = frozenset(ICommand.__fields__)
updated_properties = self.dict(exclude=excluded_fields, exclude_none=True)There was a problem hiding this comment.
I needed to add the id which is not in the ICommand fields so the code goes like this :
excluded_fields = set(ICommand.__fields__) | {"id"}
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
MartinBelthle
force-pushed
the
fix/do-not-remove-terms-in-bc
branch
from
5aab71c
to
c9d5409
Compare
laurent-laporte-pro
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback to old behavior (prior to #2052) + handle last term deletion