-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(upgrade): raise an HTTP 417 exception when an upgrade has unmet requirements #2047
fix(upgrade): raise an HTTP 417 exception when an upgrade has unmet requirements #2047
Conversation
@mabw-rte It's better to be more specific in the errors messages. For example : if it's a raw study: I'll let you correct me if there are mistakes in my suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y a des petites améliorations à faire (ou pas).
Revoir les tests unitaires : il faut simplifier.
À mon avis, les tests doivent fonctionner correctement sous Windows, car on gère seulement des cas d'erreur sans utiliser le gestionnaire de taches (c'est lui qui pose problème sous Windows).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peut-on supprimer le TODO ?
En général, on cherche quand même à avoir des messages d'erreur assez courts, par exemple :
Ici, on dit bien que ce n'est pas supporté et on dit pourquoi. |
20fc88a
to
24faa90
Compare
24faa90
to
038b164
Compare
…equirements (#2047) Context: This PR addresses two potential issues that can occur when upgrading studies: - Upgrading a variant study could potentially corrupt it. - Upgrading a parent study that has variant children could potentially corrupt those children. Issue: At present, our system does not support the upgrade of commands, which complicates the resolution of these issues. Until we develop a solution for upgrading commands, this PR implements measures to prevent the two situations mentioned above. Solution: The modifications in this PR will trigger a 417 HTTP ERROR if an attempt is made to upgrade a study that either has children or is a variant. This is a temporary measure until we implement a solution for upgrading commands.
…equirements (#2047) Context: This PR addresses two potential issues that can occur when upgrading studies: - Upgrading a variant study could potentially corrupt it. - Upgrading a parent study that has variant children could potentially corrupt those children. Issue: At present, our system does not support the upgrade of commands, which complicates the resolution of these issues. Until we develop a solution for upgrading commands, this PR implements measures to prevent the two situations mentioned above. Solution: The modifications in this PR will trigger a 417 HTTP ERROR if an attempt is made to upgrade a study that either has children or is a variant. This is a temporary measure until we implement a solution for upgrading commands.
…equirements (#2047) Context: This PR addresses two potential issues that can occur when upgrading studies: - Upgrading a variant study could potentially corrupt it. - Upgrading a parent study that has variant children could potentially corrupt those children. Issue: At present, our system does not support the upgrade of commands, which complicates the resolution of these issues. Until we develop a solution for upgrading commands, this PR implements measures to prevent the two situations mentioned above. Solution: The modifications in this PR will trigger a 417 HTTP ERROR if an attempt is made to upgrade a study that either has children or is a variant. This is a temporary measure until we implement a solution for upgrading commands.
…equirements (#2047) Context: This PR addresses two potential issues that can occur when upgrading studies: - Upgrading a variant study could potentially corrupt it. - Upgrading a parent study that has variant children could potentially corrupt those children. Issue: At present, our system does not support the upgrade of commands, which complicates the resolution of these issues. Until we develop a solution for upgrading commands, this PR implements measures to prevent the two situations mentioned above. Solution: The modifications in this PR will trigger a 417 HTTP ERROR if an attempt is made to upgrade a study that either has children or is a variant. This is a temporary measure until we implement a solution for upgrading commands.
Context:
This PR addresses two potential issues that can occur when upgrading studies:
Issue:
At present, our system does not support the upgrade of commands, which complicates the resolution of these issues. Until we develop a solution for upgrading commands, this PR implements measures to prevent the two situations mentioned above.
Solution:
The modifications in this PR will trigger a 417 HTTP ERROR if an attempt is made to upgrade a study that either has children or is a variant. This is a temporary measure until we implement a solution for upgrading commands.